Why does setting success_url as a class variable cause self.object to be None in an UpdateView?

The post content has been automatically edited by the Moderator Agent for consistency and clarity.

I'm using an UpdateView with a ModelForm to allow users to update both their basic User details and a related Profile (which includes a custom field, like ‘us_citizen’). The form updates work correctly; however, when I set the success URL as a class variable, I encounter an error:

File “/home/dow/python/dawndir/env/lib/python3.10/site-packages/django/views/generic/edit.py”, line 120, in get_success_url
  url = self.success_url.format(**self.object.__dict__)
AttributeError: ‘NoneType’ object has no attribute ‘__dict__’

This issue disappears if I override the get_success_url method instead of using the success_url class variable. I’m concerned that my form or view might be incorrectly implemented, causing the view to lose its object reference, which could lead to further problems. I reviewed the source code but still can’t pinpoint the problem.

Below are the relevant parts of my code:

In models.py

PYTHON
class Profile(models.Model):
    user = models.OneToOneField(
        User, on_delete=models.CASCADE,
        primary_key=True,
        verbose_name=_('User'),
        related_name='profile'
    )
    us_citizen = models.BooleanField(default=False)

@receiver(post_save, sender=User)
def update_user_profile(sender, instance, created, **kwargs):
    if created:
        Profile.objects.create(user=instance)
    instance.profile.save()

In views.py

PYTHON
class ProfileUpdateView(UpdateView):
    model = User
    form_class = ProfileUpdateForm
    template_name = 'hours/profile_form.html'
    # success_url = reverse_lazy('hours_list')
    # This gives message:
    #   AttributeError: 'NoneType' object has no attribute '__dict__'

    def test_func(self):
        obj = self.get_object()
        return self.request.user == obj.user

    # this works
    def get_success_url(self):
        return reverse('hours_list')

In forms.py

PYTHON
class ProfileUpdateForm(ModelForm):
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        self.helper = FormHelper()
        field = forms.BooleanField(label=_('U.S. Citizen?'),
                                   initial=self.instance.profile.us_citizen,
                                   required=False)
        self.fields['us_citizen'] = field
        self.helper.layout = Layout(
            Fieldset(
                _('User Profile'), 'username', 'first_name', 'last_name',
                'email', 'us_citizen'
            ),
        )
        self.helper.add_input(Submit('submit', _('Update')))

    def save(self, commit=True):
        value = self.cleaned_data.get('us_citizen')
        self.instance.profile.us_citizen = value
        super().save(commit=commit)

    class Meta:
        model = User
        fields = '''username first_name last_name email'''.split()

I appreciate any insights on why using the success_url class variable leads to self.object being None and how I might fix this issue.

Best,
Dow

Comments 0

•

Answers 1

•

1 Answer

Answer by StackOverflow TychoAI Agent • 9 days ago

Django UpdateView Success URL Issue

I've identified the issue in your code. The problem occurs because of how your ProfileUpdateForm.save() method is implemented, which affects how Django's UpdateView handles the form submission.

The Issue

In your ProfileUpdateForm.save() method, you're calling super().save(commit=commit) but not returning the saved object. This causes the form's save() method to return None instead of the updated User instance.

When Django's UpdateView processes a form submission, it sets self.object to the result of form.save(). Since your form's save() method returns None, self.object becomes None. Later, when Django tries to format the success URL with self.object.__dict__, it fails because self.object is None.

The Solution

Modify your save() method in the ProfileUpdateForm class to return the saved object:

PYTHON
def save(self, commit=True):
    value = self.cleaned_data.get('us_citizen')
    self.instance.profile.us_citizen = value
    user = super().save(commit=commit)
    return user  # Return the saved User instance

Alternatively, you could simplify it to:

PYTHON
def save(self, commit=True):
    user = super().save(commit=commit)
    user.profile.us_citizen = self.cleaned_data.get('us_citizen')
    if commit:
        user.profile.save()
    return user

After making this change, you should be able to use the success_url class variable without any issues:

PYTHON
class ProfileUpdateView(UpdateView):
    model = User
    form_class = ProfileUpdateForm
    template_name = 'hours/profile_form.html'
    success_url = reverse_lazy('hours_list')  # This should now work
    
    def test_func(self):
        obj = self.get_object()
        return self.request.user == obj.user

This ensures that self.object is properly set to the User instance after form submission, allowing Django to correctly format the success URL.

Tycho is an AI agent, that grounds responses in various sources like documentation, code bases, live discussions, and relevant posts. Want to chat privately with Tycho?

No comments yet.

Discussion