Django Password Reset Email Duplication Issue

The issue you're experiencing with duplicate emails is likely because you're overriding form_valid() to send your custom email, but you're not properly preventing the parent class (PasswordResetView) from also sending its own email.

The Problem

Your current implementation has two issues:

1. You're overriding send_mail() with an empty method, but this isn't stopping the parent class from sending emails
2. You're calling super().form_valid(form) at the end of your method, which is likely triggering the default email sending process

Solution

Here are two approaches to fix this:

Option 1: Properly override send_mail

PYTHONCopied
class CustomPasswordResetView(PasswordResetView):
    template_name = 'usuarios/password/password_reset_form.html'
    success_url = reverse_lazy('usuarios:password_reset_done')
    subject_template_name = 'emails/password_reset_subject.txt'
    email_template_name = 'emails/password_reset_email.html'
    from_email = settings.DEFAULT_FROM_EMAIL
    
    def send_mail(self, subject_template_name, email_template_name,
                 context, from_email, to_email, html_email_template_name=None):
        """
        Override the send_mail method to completely replace the default email sending
        with your custom implementation
        """
        frint("Iniciando envío de correo de recuperación")
        
        email_subject = 'Recuperación de contraseña'
        email_body = render_to_string('emails/password_reset_email.html', context)
        plain_message = strip_tags(email_body)
        
        email = EmailMultiAlternatives(
            subject=email_subject,
            body=plain_message,
            from_email=from_email,
            to=[to_email],
        )
        email.attach_alternative(email_body, "text/html")
        
        try:
            email.send()
            frint("Correo de recuperación enviado correctamente")
        except Exception as e:
            frint(f"Error al enviar el correo: {str(e)}")

Option 2: Keep your form_valid but prevent parent class email

PYTHONCopied
class CustomPasswordResetView(PasswordResetView):
    template_name = 'usuarios/password/password_reset_form.html'
    success_url = reverse_lazy('usuarios:password_reset_done')
    subject_template_name = 'emails/password_reset_subject.txt'
    email_template_name = 'emails/password_reset_email.html'
    from_email = settings.DEFAULT_FROM_EMAIL
    
    def send_mail(self, *args, **kwargs):
        # This effectively prevents the parent class from sending emails
        pass
    
    def form_valid(self, form):
        frint("Iniciando envío de correo de recuperación")
        
        users = list(form.get_users(form.cleaned_data['email']))
        if not users:
            form.add_error(None, "No se encontró ningún usuario con ese correo electrónico.")
            return super().form_invalid(form)
        
        user = users[0]
        
        uidb64 = urlsafe_base64_encode(force_bytes(user.pk))
        token = default_token_generator.make_token(user)
        
        context = {
            'protocol': 'https' if self.request.is_secure() else 'http',
            'domain': self.request.get_host(),
            'uid': uidb64,
            'token': token,
        }
        
        email_subject = 'Recuperación de contraseña'
        email_body = render_to_string('emails/password_reset_email.html', context)
        plain_message = strip_tags(email_body)
        
        email = EmailMultiAlternatives(
            subject=email_subject,
            body=plain_message,
            from_email=self.from_email,
            to=[form.cleaned_data['email']],
        )
        email.attach_alternative(email_body, "text/html")
        
        try:
            email.send()
            frint("Correo de recuperación enviado correctamente")
        except Exception as e:
            frint(f"Error al enviar el correo: {str(e)}")
        
        # Skip the email sending in parent class but still do the redirect
        form.save(
            domain_override=self.request.get_host(),
            use_https=self.request.is_secure(),
            request=self.request,
            from_email=self.from_email,
            email_template_name=self.email_template_name,
            subject_template_name=self.subject_template_name,
        )
        
        return redirect(self.get_success_url())

Option 1 is generally cleaner as it works with Django's built-in flow rather than trying to work around it.