Chamfer Feature Implementation Analysis

Looking at your code for implementing a chamfer feature using a distance-angle approach, I can identify a few potential issues that might be causing unexpected results.

Issues and Recommendations

1. Direction Vector Rotation

Your approach to rotating the direction vectors seems to have some issues. When you're rotating both direction vectors by the same angle, it doesn't correctly create a chamfer with the expected angle between the original lines.

JAVASCRIPTCopied
// Current rotation approach
const rotatedFirstDirection = new Vector3(
  firstDirection.x * Math.cos(angleInRadians) - firstDirection.y * Math.sin(angleInRadians),
  firstDirection.x * Math.sin(angleInRadians) + firstDirection.y * Math.cos(angleInRadians),
  0
).normalize();

For a chamfer, you typically want to move a specific distance along each original line from the intersection point.

2. Clockwise Detection

The clockwise detection logic might not be working correctly:

JAVASCRIPTCopied
const isClockwise = clicksNormal[0].dot(clicksNormal[1]).z < 0;

The dot product returns a scalar, not a vector, so .z would be undefined. You might want to use the cross product instead to determine orientation.

3. Angle Calculation

For a distance-angle chamfer, the angle typically refers to the angle of the chamfer line itself, not the rotation angle to apply to the direction vectors.

Suggested Implementation

Here's a revised approach for the drawChamferLineWithDegree function:

JAVASCRIPTCopied
function drawChamferLineWithDegree(angle, distance) {
  const store = window.myApp._context.provides.store;
  const sketchBody = store.getters.getSelectedSketches[0];
  const selectedObjects = store.getters.getSelectedObjects;

  // Calculate intersection point
  const intersectPoint = calculateIntersection(selectedObjects);
  
  // Get direction vectors from intersection to selection points
  const firstClick = selectedObjects[0].userData.selectCoordinates;
  const secondClick = selectedObjects[1].userData.selectCoordinates;
  
  const firstDirection = firstClick.clone().sub(intersectPoint).normalize();
  const secondDirection = secondClick.clone().sub(intersectPoint).normalize();
  
  // Calculate the angle between the two lines
  const lineAngle = Math.acos(firstDirection.dot(secondDirection));
  
  // Calculate the distance to move along each line
  // For a chamfer with a specific angle, we need to calculate the distances
  const angleInRadians = MathUtils.degToRad(angle);
  const distanceAlongLine = distance / Math.sin(angleInRadians);
  
  // Calculate chamfer points
  const startPoint = intersectPoint.clone().add(firstDirection.clone().multiplyScalar(distanceAlongLine));
  const endPoint = intersectPoint.clone().add(secondDirection.clone().multiplyScalar(distanceAlongLine));
  
  // Create chamfer line
  const chamferLine = constructorLine([startPoint, endPoint]);
  chamferLine.material.color.set(0xff0000);
  chamferLine.userData.distance = distance;
  chamferLine.userData.angle = angle;
  chamferLine.userData.intersectPoint = intersectPoint;
  chamferLine.userData.directions = { firstDirection, secondDirection };
  chamferLine.userData.localPoints = [startPoint, endPoint];
  chamferLine.userData.points = [startPoint, endPoint];
  
  store.commit('setSelectedObjects', [...selectedObjects, chamferLine]);
  sketchBody.add(chamferLine);
}

And for the update function:

JAVASCRIPTCopied
function updateChamferGroupWithDegree(selectedLines, chamferLine, angle, distance) {
  const intersectPoint = chamferLine.userData.intersectPoint.clone();
  const { firstDirection, secondDirection } = chamferLine.userData;
  
  // Calculate the angle between the two lines
  const lineAngle = Math.acos(firstDirection.dot(secondDirection));
  
  // Calculate the distance to move along each line
  const angleInRadians = MathUtils.degToRad(angle);
  const distanceAlongLine = distance / Math.sin(angleInRadians);
  
  // Calculate chamfer points
  const firstChamferPoint = intersectPoint.clone().add(firstDirection.clone().multiplyScalar(distanceAlongLine));
  const secondChamferPoint = intersectPoint.clone().add(secondDirection.clone().multiplyScalar(distanceAlongLine));
  
  // Update chamfer line
  chamferLine.geometry.setFromPoints([firstChamferPoint, secondChamferPoint]);
  
  // Update original lines
  const firstLineIndex = selectedLines.value[0].userData.dinamic.i;
  const secondLineIndex = selectedLines.value[1].userData.dinamic.i;
  
  selectedLines.value[0].userData.dinamic.points[firstLineIndex].copy(firstChamferPoint);
  selectedLines.value[1].userData.dinamic.points[secondLineIndex].copy(secondChamferPoint);
  
  selectedLines.value[0].geometry.setFromPoints(selectedLines.value[0].userData.dinamic.points);
  selectedLines.value[1].geometry.setFromPoints(selectedLines.value[1].userData.dinamic.points);
  
  // Update children if they exist
  if (selectedLines.value[0].children[firstLineIndex]) {
    selectedLines.value[0].children[firstLineIndex].geometry.setFromPoints([firstChamferPoint]);
  }
  if (selectedLines.value[1].children[secondLineIndex]) {
    selectedLines.value[1].children[secondLineIndex].geometry.setFromPoints([secondChamferPoint]);
  }
}

This approach calculates the distance to move along each original line based on the desired chamfer angle and distance, which should give you a more accurate chamfer feature.

Note that this is a simplified approach and might need adjustments based on your specific requirements and coordinate system.